Update the repository from fork laget.se/ical net #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed `runs-on` to `ubuntu-latest` in `publish.yml` and `tests.yml`. - Added `fetch-depth: 0` to `actions/checkout@v4` in both workflows. - Added `Get version tag` step in `publish.yml`. - Included `-p:nowarn=1591` in `Build` steps to suppress warnings. - Changed `Test` verbosity to `quiet` in both workflows. - Updated `Build and pack for publishing` in `publish.yml` to use `VERSION`. - Updated `Store artifacts` step in `publish.yml` for new naming convention. - Updated `Push package to NuGet` step in `publish.yml` to use `VERSION`.
Updated the `ProdId` constant in `LibraryMetadata` class within `Constants.cs` to reflect a new GitHub organization. Changed the value from `"-//github.com/rianjs/ical.net//NONSGML ical.net 4.0//EN"` to `"-//github.com/ical-org/ical.net//NONSGML ical.net 4.0//EN"`. Modified the `NodaTime` package reference in `Ical.Net.csproj` to use a wildcard for the patch version, changing from `"3.1.11"` to `"3.1.*"` to allow for automatic updates to any 3.1.x version.
* Update `Ical.Net.Tests.csproj` and `Ical.Net.csproj` to include assembly signing by adding `SignAssembly` and `AssemblyOriginatorKeyFile` properties. * Replace `InternalsVisibleTo` with `AssemblyAttribute` including a public key in `Ical.Net.csproj`. * Add `IcalNetStrongnameKey.snk` for strong name key.
Avoid mixing up with public virtual property AssociatedObject
Refactored the ListForIndex method in GroupedList.cs to use the FirstOrDefault LINQ method instead of a foreach loop with a Where clause. This change simplifies the code and improves performance. Added a null check to handle cases where no matching list is found, ensuring the method returns null and sets relativeIndex to -1.
* Refactored `GetZone` method to use `FirstOrDefault` for finding matching time zone IDs, simplifying the code by removing `foreach` loops. * Reused and reassigned `providerId` variable. Streamlined condition checks and retrieval of time zones.
…dling * Replaced `SimpleCalendar` static field with `CreateSimpleCalendar` method. `CreateSimpleCalendar` now creates a `CalendarEvent` and adds it to the `Calendar`. * Removed `_aTzid`, `SimpleCalendar`, and `_e` static fields, integrating their functionality into `CreateSimpleCalendar`.
Modified the SetValueType method in CalendarDataType.cs to convert the 'type' variable to uppercase only if it is not null, removing the redundant null-coalescing operation. This change potentially avoids a null reference exception.
Duration cannot be assigned to null, we check for default value
Duration cannot be assigned to null, we check for default value
axunonb
force-pushed
the
update-from-laget-se-ical-net
branch
from
f11dde6 to
3bfe42c
Compare
Introduced a new static class `RegexDefaults` in `Constants.cs` to define default values for regular expressions, including a default timeout of 200 milliseconds. Updated various `Regex` instances across multiple files (`DateTimeSerializer.cs`, `RecurrencePatternSerializer.cs`, `RequestStatusSerializer.cs`, `StringSerializer.cs`, `TimeSpanSerializer.cs`, `UtcOffsetSerializer.cs`, `WeekDaySerializer.cs`, `SimpleDeserializer.cs`, `TextUtil.cs`) to use the new `RegexDefaults.Timeout` for specifying the timeout parameter.
axunonb
force-pushed
the
update-from-laget-se-ical-net
branch
from
3bfe42c to
ae4bd4f
Compare
|
This was referenced Oct 13, 2024
AddTimeZone(string, DateTime, bool) fails if the DateTime parameter is a leap day (February 29)
#583
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
laget.se/ical netApply the following change after the update:
readme.mdpublish.ymlandtests.ymlruns-ontoubuntu-latest.fetch-depth: 0toactions/checkout@v4in both workflows.Get version tagstep inpublish.yml.-p:nowarn=1591inBuildsteps to suppress warnings.Testverbosity toquietin both workflows.Build and pack for publishinginpublish.ymlto useVERSION.Store artifactsstep inpublish.ymlfor new naming convention.Push package to NuGetstep inpublish.ymlto useVERSION.Ical.Net.Tests.csprojandIcal.Net.csprojto include assembly signing by addingSignAssemblyandAssemblyOriginatorKeyFileproperties.InternalsVisibleTowithAssemblyAttributeincluding a public key inIcal.Net.csproj.IcalNetStrongnameKey.snkfor strong name key.RegexDefaultsand update all Regex withRegexDefaults.Timeoutwhich is set to 200 millisecondsThis PR closes the following PRs which have previously been merged into
laget.se/ical netCloses #491
Closes #443
Closes #525
Closes #528
Closes #571
Closes #579
Closes #584
Closes #595