Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Ical.Net.Tests project from NUnit3 to NUnit 4 #613

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

axunonb
Copy link
Collaborator

@axunonb axunonb commented Oct 17, 2024

  • Migrate NUnit 3.14.0 to 4.2.2
  • Add NUnit.Analyzers 4.3.0
  • Convert Classic Assert to Constraint Model
  • Introduce Assert.Multiple to group assertions, ensuring all are evaluated even if some fail.
  • Simplify test case source return types to IEnumerable without a type argument
  • Remove unused using directives and added necessary ones.

Test logic is left unchanged except for 7 tests in Exception context.
Here all try...catch blocks are replaced with Throws. assertions.

Closes #611

* Migrate NUnit 3.14.0 to 4.2.2
* Add NUnit.Analyzers 4.3.0
* Convert Classic Assert to Constraint Model
* Introduce Assert.Multiple to group assertions, ensuring all are evaluated even if some fail.
* Simplify test case source return types to IEnumerable without a type argument
* Remove unused using directives and added necessary ones.

Test logic is left unchanged except for 7 tests in Exception context.
Here all try...catch blocks are replaced with `Throws.` assertions.
@axunonb axunonb changed the title Migrated Ical.Net.Tests rpoject from NUnit3 to NUnit 4 Migrated Ical.Net.Tests project from NUnit3 to NUnit 4 Oct 17, 2024
@axunonb axunonb requested a review from minichma October 17, 2024 14:28
@axunonb
Copy link
Collaborator Author

axunonb commented Oct 19, 2024

@minichma Please take a look, if time allows. Can we merge this PR?

@minichma
Copy link
Collaborator

Sure, will have a look right now.

minichma
minichma previously approved these changes Oct 19, 2024
Copy link
Collaborator

@minichma minichma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was just a very quick review, more an optical one. Found just a few formatting issues.

Ical.Net.Tests/RecurrenceTests.cs Outdated Show resolved Hide resolved
Ical.Net.Tests/SimpleDeserializationTests.cs Show resolved Hide resolved
Ical.Net.Tests/TodoTest.cs Show resolved Hide resolved
Copy link

@axunonb axunonb merged commit 9070096 into ical-org:main Oct 19, 2024
2 checks passed
@axunonb axunonb deleted the pr/nunit4-migraton branch October 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate unit tests from NUnit v3 to v4
2 participants