Skip to content
This repository has been archived by the owner on May 9, 2020. It is now read-only.

feat: support register provider with mpa #283

Merged
merged 3 commits into from
Apr 27, 2020
Merged

feat: support register provider with mpa #283

merged 3 commits into from
Apr 27, 2020

Conversation

chenbin92
Copy link
Contributor

@chenbin92 chenbin92 requested a review from ClarkXia April 26, 2020 12:21
@chenbin92 chenbin92 self-assigned this Apr 26, 2020
ClarkXia
ClarkXia reviewed Apr 27, 2020
View reviewed changes
packages/plugin-store/src/babelPluginReplacePath.ts Outdated
const matchedPagePath = matchRelativePath(routesPath, value, applyMethod) || matchAliasPath(alias, value, applyMethod);
if (matchedPagePath && pathRegExp.test(matchedPagePath)) {
if (matchedPagePath && (pathRegExp.test(matchedPagePath) || isMpa)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mpa 中其他导入文件需要考虑下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新

@chenbin92 chenbin92 merged commit f094c7d into release-next Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/support-mpa-register-provider branch April 27, 2020 04:03
@chenbin92 chenbin92 mentioned this pull request Apr 27, 2020
Merged
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ClarkXia ClarkXia ClarkXia approved these changes

Assignees

@chenbin92 chenbin92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenbin92 @ClarkXia