-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.1.0 #65
Release 1.1.0 #65
Conversation
alvinhui
commented
Feb 24, 2020
•
edited
Loading
edited
- feature: effects && reduces;
- docs: Upgrade guidelines and Releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
docs/recipes.md
Outdated
}, | ||
}, | ||
reducers: { | ||
setState(prevState, payload) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里命名 update 会不会好一点?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/recipes.md
Outdated
} | ||
``` | ||
|
||
### Bind View |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binding view
|
||
`useActionsState(): { [actionName: string]: { isLoading: boolean, error: Error } } ` | ||
`useEffectsState(): { [actionName: string]: { isLoading: boolean, error: Error } } ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useEffectsState 应该是 useModelEffectsState ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createModel 的返回是 useEffectsState
createStore 的返回是 useModelEffectsState
effects = {}, | ||
reducers = {}, | ||
} = config; | ||
const mergedEffects = { ...defineActions, ...effects }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
核心看起来就是这个合并了,我理解如果已有项目只有 actions 还是会有之前的 bug 是吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,已有项目只有 actions 还是会有之前的 bug