Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0 #65

Merged
merged 14 commits into from
Mar 5, 2020
Merged

Release 1.1.0 #65

merged 14 commits into from
Mar 5, 2020

Conversation

alvinhui
Copy link
Member

@alvinhui alvinhui commented Feb 24, 2020

  • feature: effects && reduces;
  • docs: Upgrade guidelines and Releases.

@alvinhui alvinhui requested a review from chenbin92 February 24, 2020 08:40
@alvinhui alvinhui self-assigned this Feb 24, 2020
@alvinhui alvinhui changed the title [WIP] Release 1.1.0 Release 1.1.0 Mar 4, 2020
Copy link
Contributor

@chenbin92 chenbin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

docs/api.md Show resolved Hide resolved
docs/recipes.md Outdated
},
},
reducers: {
setState(prevState, payload) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里命名 update 会不会好一点?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs/recipes.md Outdated Show resolved Hide resolved
docs/recipes.md Outdated
}
```

### Bind View
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binding view

docs/api.md Show resolved Hide resolved

`useActionsState(): { [actionName: string]: { isLoading: boolean, error: Error } } `
`useEffectsState(): { [actionName: string]: { isLoading: boolean, error: Error } } `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useEffectsState 应该是 useModelEffectsState ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createModel 的返回是 useEffectsState
createStore 的返回是 useModelEffectsState

effects = {},
reducers = {},
} = config;
const mergedEffects = { ...defineActions, ...effects };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

核心看起来就是这个合并了,我理解如果已有项目只有 actions 还是会有之前的 bug 是吧

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,已有项目只有 actions 还是会有之前的 bug

docs/api.md Outdated Show resolved Hide resolved
@chenbin92 chenbin92 merged commit cc5c015 into master Mar 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the release/1.1.0 branch March 5, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants