Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu: Update to 0.10 #1000

Merged
merged 6 commits into from
Aug 25, 2021
Merged

wgpu: Update to 0.10 #1000

merged 6 commits into from
Aug 25, 2021

Conversation

PolyMeilex
Copy link
Contributor

@PolyMeilex PolyMeilex commented Aug 19, 2021

  • blocked by: Update to wgpu 0.10 hecrj/wgpu_glyph#73 (no longer blocking)
  • Opengl backedn of wgpu now works as expected in iced (I never managed to run it in prev versions, but now it works)
    • EDIT: nope, never mind, on my second device it does not work at all, so it's still unstable (at least on linux)
  • Images in OpenGL are for some reason black, I will investigate this a little bit more soon.
  • Wgpu SwapChain not longer exists, so surface was added as an argument to draw() in compositor trait, wgpu implementation of compositors uses () as a SwapChain type now.

Fixes #933.

@PolyMeilex PolyMeilex marked this pull request as ready for review August 19, 2021 01:23
@kvark
Copy link

kvark commented Aug 19, 2021

Please file issues about OpenGL backend!

@PolyMeilex
Copy link
Contributor Author

PolyMeilex commented Aug 21, 2021

@hecrj hecrj added the improvement An internal improvement label Aug 25, 2021
@hecrj hecrj added this to the 0.4.0 milestone Aug 25, 2021
@hecrj hecrj added the bug Something isn't working label Aug 25, 2021
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PolyMeilex! 🎉

I think this is ready to merge!

@hecrj hecrj merged commit 2d65621 into iced-rs:master Aug 25, 2021
@PolyMeilex PolyMeilex deleted the wgpu-0.10 branch August 25, 2021 09:25
@PolyMeilex
Copy link
Contributor Author

After update of deps (maybe new naga?), text is no longer rendered in OpenGL backend... I'm kinda tired of debugging OpenGL backend, if I'll find some free time I will try to find a reason for this and report it (probably upstream)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement An internal improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WGPU 0.9 breaks Image rendering [AMD Integrated]
3 participants