Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with text selection in text_input widget #1098

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

cmot17
Copy link
Contributor

@cmot17 cmot17 commented Oct 24, 2021

Broken behavior before this PR:

2021-10-23.14-57-31.mp4

Fixed behavior with this PR:

2021-10-24.09-01-40.mp4

Also I don't really know how to avoid the addition to .gitignore, hopefully that isn't an issue?

@thenlevy
Copy link
Contributor

Regarding the .gitignore addition you can avoid it by doing the following

git reset --mixed HEAD^ (this "undo the commit" without changing the files)
cargo fmt
git add native/src/widget/text_input.rs
git commit -m "Fix issue with text selection in text_input widget" (notice that it's only -m and not -am)
git push --force your_github_repo this will replace the commit you submitted in this PR by an other one without the unnecessary editing to .gitingore and with proper formatting

@hecrj hecrj added the bug Something isn't working label Oct 25, 2021
@hecrj hecrj added this to the 0.4.0 milestone Oct 25, 2021
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

I have rebased and deleted the .gitignore changes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants