-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PickList
text wrapping
#1318
Conversation
This was intended to some extent. Basically, I wanted to avoid an unconditional Since a We may be able to fix the issue for now by just changing the Once the text caching issues are fixed, we can revisit this! |
@hecrj Makes sense w/ the performance consideration of using a new layer. I tried using Top alignment with manually centered y placement and this works, however the wrapped text still "overflows" below the picklist quad since we don't have any clipping in place. This is actually less preferred as the wrapped text leaves the quad, whereas with Center it at least is wrapped mostly within the quad. Let's leave this until text caching has been addressed. Thanks! Edit: Disregard, I just needed to restrict the height of the text primitive to text size and it no longer overflows. I think this is a good intermediate solution. |
b9619e9
to
d562c27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks 🙇
PickList text is wrapped if the pick list is set to a fixed width and the selected text is wider than the fixed width. This resolves the issue by giving the rendered text bounds an infinite width so it doesn't wrap. A layer / clip needs to be provided to prevent text overflow.
I can't imagine wrapping is intended since the height is fixed to
text_size
and 2 lines of wrapped text insidetext_size
doesn't look good at all. This seems like a more sane default to handle text overflow.