Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework scaling in clock example #251

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Rework scaling in clock example #251

merged 2 commits into from
Apr 1, 2020

Conversation

Plecra
Copy link
Contributor

@Plecra Plecra commented Apr 1, 2020

I quite like the clock example as an example of iced's reactivity, but it doesn't directly scale the clock hands at the moment, leading to a strange effect with smaller windows

The clock at full scale
The clock scaled down, but the hands are the same width

I scaled the hands with the same factor as the face to make it feel more consistent:

A small clock with the same proportions as the full-scale image

Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@hecrj hecrj merged commit 2fa6edf into iced-rs:master Apr 1, 2020
@hecrj hecrj added the improvement An internal improvement label Apr 1, 2020
@hecrj hecrj added this to the 0.1.0 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An internal improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants