fix rectangle snapping #2768
Open
fix rectangle snapping #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwloef
force-pushed
the
fix_rectangle_snap
branch
from
e10a687 to
2e7cc25
Compare
hecrj
requested changes
Jan 31, 2025
I don't think that truncate is less correct than rounding in this case, either should be fine. Truncate seems more intuitive to me though since it is the default way of casting float to int. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2753
Before, the whole rectangle was moved towards the top left (to align the top left point), then the bottom right point was aligned after being moved up. Now the top left point is aligned independently of the bottom right point.