image viewer: Only calculate viewport based width/length for Length::Unit|Shrink #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently image::viewer will not expand it's image into empty space even when Length::Fill or Length::FillPortion are used. Only calculate viewport when viewer cannot expand.
hecrj
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently image::viewer will not expand it's image into empty space even when
Length::FillorLength::FillPortionare used and space is available.This is because height/width is always calculated with viewport. In my eyes, viewport shouldn't have an influence if the layout size isn't constrained to the size that the viewport is limiting to.
Instead of always, only calculate viewport based length/width when the image has Length::Unit or Length::Shrink.
I might be missing something, so corrections are very welcome.
Fixes #878