Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add cupertino spinner #105

Merged
merged 3 commits into from
Mar 13, 2023
Merged

✨ Add cupertino spinner #105

merged 3 commits into from
Mar 13, 2023

Conversation

bbyler
Copy link
Contributor

@bbyler bbyler commented Mar 13, 2023

UPDATE:
I ran cargo fmt, as indicated. The PR is larger now. cargo fmt reformatted all of the existing examples. There are 10 original files that changed according to this PR.

Hello!

Pulling inspiration from Flutter's cross-platform widgets (e.g. Flutter Cupertino Widgets ), I'd like to start adding "Cupertino"-style widgets to Iced (iced_aw).

This PR holds the spinner. I've attached a GIF to show it in action, and the example attached demonstrates how to get started.

Please let me know if you have any questions/feedback! This has only been tested on my Mac desktop, but it should be fine on any native. This should work for web too.

The spinner is not necessarily "official", but it's quite close, from following the Flutter implementation's constants (which are more official). If you have ideas for how to tweak any pixel/colour to get it just right, feel free to chime in!

Design

CupertinoSpinner

See

  1. Flutter Activity Indicator
  2. Flutter Cupertino Widgets

for reference. The Flutter source is used for constants. The implementation for this widget pulls together ideas from:

1. the mainline Clock example
2. the existing `iced_aw` Spinner
3. the Flutter Activity Indicator above
4. the QR Code widget

Cargo.toml Outdated Show resolved Hide resolved
@genusistimelord
Copy link
Collaborator

need to fix formatting run cargo fmt on the entire project then save any changes.

@genusistimelord genusistimelord merged commit 3bf88a8 into iced-rs:main Mar 13, 2023
@genusistimelord
Copy link
Collaborator

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants