Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper Methods Hotfixes #168

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Helper Methods Hotfixes #168

merged 2 commits into from
Aug 14, 2023

Conversation

bbb651
Copy link
Contributor

@bbb651 bbb651 commented Aug 14, 2023

I was trying to use these in a projects and noticed they don't compile.

It would be nice to have CI at least for testing things actually compile so things like this don't make it into releases. Nevermind there is CI, it probably just doesn't cover different feature flags and the specific helper

@bbb651 bbb651 changed the title Fixed {horizontal,vertical}_wrap! using wrong path Helper hotfixes Aug 14, 2023
@bbb651 bbb651 changed the title Helper hotfixes Helper Methods Hotfixes Aug 14, 2023
Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh nice catch. was a missed thing during testing too since we did not test the helpers. thank you

@genusistimelord genusistimelord merged commit d2c0441 into iced-rs:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants