Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'onBlockBreakout' option to execute a callback when a block brakes #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AddeNordh
Copy link

No description provided.

@makenosound
Copy link
Member

@AddeNordh Thanks for the PR. Just wondering what the use case here is for the callback? I’m not against adding something like what you’ve added, but would like to think through how we can make it potentially more useful if we do add a callback param.

@AddeNordh
Copy link
Author

@makenosound thanks for the reply, gotta admit i was losing hope 😆
Well when i was using the plugin on my most recent project i found myself quite often, in my specific case, needing the block that "broke" to disable an active class from the editors menu.
To be honest i haven't really put much thought into what other use cases this might have, just thought it could be a useful thing to have for some specific things.

@makenosound
Copy link
Member

Ah, right. I’m not totally convinced that using the type in a callback is the right way to do that — feels like you’d want that to be determined from the selection whenever the EditorState changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants