Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlencoded filter values #12

Open
apmuthu opened this issue Jan 25, 2019 · 1 comment
Open

urlencoded filter values #12

apmuthu opened this issue Jan 25, 2019 · 1 comment

Comments

@apmuthu
Copy link
Contributor

apmuthu commented Jan 25, 2019

When we use the defineAllowableValues method to provided for a drop down select box for any filter field that has spaces in it's potential values, the said field displays a blank in the table listing.
This may be rectified by urldecode of the filter value before usage at line 1302 by changing:

$filter_value = $_REQUEST[$field];

to be:

$filter_value = urldecode($_REQUEST[$field]);
apmuthu added a commit to apmuthu/ajaxcrud that referenced this issue Jan 25, 2019
apmuthu added a commit to apmuthu/ajaxcrud that referenced this issue Jan 26, 2019
@apmuthu
Copy link
Contributor Author

apmuthu commented Jan 27, 2019

The fix in my last commit is the actually correct one.
The line 1685 in this ajaxCRUD.class.php:

$list_val = $list[0];

should become:

$list_val = urldecode($list[0]); // manual urldecode as no js here

In general, the js files manage the urldecode but for the form (add record), it needs to be in php here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant