Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: MR naming possibility #267

Closed
iamthevoid opened this issue Dec 6, 2021 · 1 comment · Fixed by #292
Closed

Feature Request: MR naming possibility #267

iamthevoid opened this issue Dec 6, 2021 · 1 comment · Fixed by #292
Assignees
@Alex009
Labels
enhancement New feature or request
Milestone
0.18.0

Comments

@iamthevoid
Copy link

iamthevoid commented Dec 6, 2021 •
edited
Loading

In multimodule project there are many MR's can be generated.

If i try to call they from swift i stuck into naming problem. Interop make MR, MR_, MR__ ... from they

It is too bad for using in production, because it is impossible to predict what name new MR from another module will get.

For example If i use 100 strings from MR, 50 from MR_ in Swift code nobody can garauntee that new module MR wont't became MR or MR_ and old code breaks.

At the time it can be solved with typealiases, but looks like it should be part of library logic
@Alex009 Alex009 added the enhancement New feature or request label Dec 16, 2021
@Alex009 Alex009 added this to the 0.18.0 milestone Dec 16, 2021
@Alex009 Alex009 self-assigned this Jan 22, 2022
Alex009 added a commit that referenced this issue Jan 22, 2022
@Alex009
#267 generated class name configuration
ddc4064
Alex009 added a commit that referenced this issue Jan 22, 2022
@Alex009
Merge remote-tracking branch 'origin/develop' into #267-mr-class-rena…
7724506 
…me-possibility

# Conflicts:
#	resources-generator/src/main/kotlin/dev/icerock/gradle/MultiplatformResourcesPlugin.kt
@Alex009 Alex009 linked a pull request Jan 22, 2022 that will close this issue
#267 generated class name configuration #292
Merged
Alex009 added a commit that referenced this issue Jan 22, 2022
@Alex009
Merge pull request #292 from icerockdev/#267-mr-class-rename-possibility
c8427ee 
#267 generated class name configuration
@Alex009
Copy link
Member

Alex009 commented Jan 22, 2022

will be available in 0.18.0

@Alex009 Alex009 closed this as completed Jan 22, 2022
@Alex009 Alex009 mentioned this issue Jan 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex009 Alex009

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

#267 generated class name configuration icerockdev/moko-resources
2 participants
@Alex009 @iamthevoid