Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加了设计尺寸的参数 #40

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Conversation

Grewer
Copy link
Contributor

@Grewer Grewer commented Nov 5, 2020

首先设计图默认了是 750, 但是 ui 给的不是 750, 这是我修改的起因

再是参数是直接写在了 iconfont-js.json 里面
这个参数在 taro 的 config/index.js 文件下也有, 但是在这个文件里面, 是可以使用 es6 的语法 import ,
当前的node 脚本不支持,那么只能使用在 json 里添加参数了

@fwh1990
Copy link
Member

fwh1990 commented Nov 6, 2020

Hello,模板这边漏掉了,其他没问题,感谢您的付出。 https://github.com/iconfont-cli/taro-iconfont-cli/blob/master/src/libs/iconfont.json

@fwh1990
Copy link
Member

fwh1990 commented Nov 6, 2020

添加配置是一种方案。另一种方案是内置一个taro plugin,可以快速地拿到config里的designWidth,然后设置到process.env.DESIGN_WIDTH就行了。

@Grewer
Copy link
Contributor Author

Grewer commented Nov 6, 2020

已添加

@fwh1990 fwh1990 merged commit 6c0daac into iconfont-cli:master Nov 6, 2020
@fwh1990
Copy link
Member

fwh1990 commented Nov 6, 2020

3.1.0 已经发布

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants