Code conversion breaks within one minute with a big object reference error dialog.

[Panchraj]

Steps to reproduce

1. Right click on my VB.net Project named OFMEngine.
2. it displays below info in output window.
   Building solution prior to conversion for maximum accuracy...
   Converting OFMEngine...
3. Then it display a big dialog error having below information.

Error message shown

---

Code converter 8.4.3 - Visual Studio 16.11.31911.196

An error has occurred during conversion - press Ctrl+C to copy the details: System.NullReferenceException: Object reference not set to an instance of an object.
at ICSharpCode.CodeConverter.CSharp.ProjectMergedDeclarationExtensions.d__2.MoveNext()

detailed error is attached.
VB to Csharp Conversion error.txt

[GrahamTheCoder]

Thanks for the report, I'll try to figure out what is null. I may need more info about the project file to verify any fix since it likely relates to a referenced resx

CodeConverter/CodeConverter/CSharp/ProjectMergedDeclarationExtensions.cs

Lines 45 to 54 in 0c39437

	public static IEnumerable<(string RelativePath, string LastGenOutput)> ReadVbEmbeddedResources(this Project vbProject)
	{
	if (vbProject.FilePath == null || !File.Exists(vbProject.FilePath)) yield break;
	var projXml = XDocument.Load(vbProject.FilePath);
	var xmlNs = projXml.Root.GetDefaultNamespace();
	foreach (var resx in projXml.Descendants().Where(IsStandaloneGeneratedResource)) {
	string relativePath = GetIncludeOrUpdateAttribute(resx).Value;
	string lastGenOutput = resx.Element(xmlNs + "LastGenOutput").Value;
	yield return (relativePath, Path.Combine(Path.GetDirectoryName(relativePath), lastGenOutput));
	}

[Panchraj]

Project file is attached.
OFMEngine.txt

[GrahamTheCoder]

Thanks, I'll try to take a look soon

[Panchraj]

Thanks for resolving the issue on high priority basis. I am using the code converter as visual studio extension. So kindly update the same.

…

On Fri, 31 Dec 2021, 17:06 GrahamTheCoder, ***@***.***> wrote: Closed #804 <#804> via f991566 <f991566> . — Reply to this email directly, view it on GitHub <#804 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHSXN4OZOM6P4XXNZFWOYYDUTWIS3ANCNFSM5K4FDTQA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[GrahamTheCoder]

The code will go out in the next release (probably in the next week or two). In the meantime if you need the fix, you can uninstall the current extension, and install the CI build (the VSIX) from the bottom of this page: https://github.com/icsharpcode/CodeConverter/actions/runs/1640619541
Let me know if it works for you, thanks!

[Panchraj]

Now its working fine. Thanks a lot.

[GrahamTheCoder]

Great, thanks!