Vb to cs trivia #518
Merged
Vb to cs trivia #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: * StatementTests show comments that are lost (or sometimes moved upwards significantly * Multi file tests show comment at top of class ending up at the end - see end of TestData\MultiFileCharacterization\VBToCSResults\ConvertWholeSolution\VbLibrary\My Project\MyNamespace.Static.Designer.cs * method block doc comments end up on the class (or element) above where they come from * Formatting of local functions seems to always use one line even when there are multiple statements
If this problem turns up a lot we could consider having the syntax tree to check against available in the visitor wrapper
System first, then alphabetically, preferring those that have source mappings
Trivia is always only mapped once now
Might be worth a general solution to this problem for identifiers, e.g. annotating them with an id and only using the first of them
|
Also fixes #436 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #506
Fixes #436
Problem
VB -> CS comment conversion can lose comments at the moment, and it's quite hard for a given testcase to get the comments back in the right place.
Solution
This PR moves over to using the LineTriviaMapper (newly written for CS -> VB comments but can be applied completely generally)
Future PR: Basic conversions for if directives and regions (Extend
ConvertVBTriviamethod)