Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# -> VB: various fixes #533

Merged
merged 17 commits into from
Mar 5, 2020
Merged

C# -> VB: various fixes #533

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
30e5b3e
C# -> VB: convert PrefixUnaryExpression
Alexilia Feb 17, 2020
9e40c64
C# -> VB: rename members when they are conflicted with interface members
Alexilia Feb 18, 2020
71012fd
C# -> VB: continue rename subsequent members
Alexilia Feb 19, 2020
8dda51b
C# -> VB: improve equals expression for strings
Alexilia Feb 19, 2020
f27a51e
Merge branch 'work'
Alexilia Feb 25, 2020
376f3b9
CS -> VB: duplicating imports
Alexilia Feb 25, 2020
e1bda96
Merge remote-tracking branch 'upstream/master'
Alexilia Feb 25, 2020
c468d5d
Merge branch 'master' into alexilia-master
GrahamTheCoder Mar 2, 2020
c981596
Remove commented
GrahamTheCoder Mar 2, 2020
170de31
Fix post merge compile error
GrahamTheCoder Mar 2, 2020
3ad34f8
Add self verifying tests
GrahamTheCoder Mar 2, 2020
6fbafbb
Fix bug with arrow expression void methods
GrahamTheCoder Mar 2, 2020
16d84a8
update tests
Alexilia Mar 4, 2020
66008b6
Add back tests which show flaw in this PR's implementation
GrahamTheCoder Mar 5, 2020
f32c2b8
Reduce tests cases to focus on a single case - null literal
GrahamTheCoder Mar 5, 2020
64de292
Use Equals and recharacterize tests
GrahamTheCoder Mar 5, 2020
5a84966
Remove redundant files
GrahamTheCoder Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Tests/TestData/SelfVerifyingTests/CSToVB/StringEqualityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,17 @@ public class StringEqualityTests
private char[] emptyCharArray = new char[0];

[Fact]
public void NullEmptyStringEqualsOperator() => Assert.False(nullString == emptyString);
public void NonInternStringsEqualsOperator() {
string a = "10";
string b = 10.ToString(); //strings created in runtime are not interned
Assert.True(a == b);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I like this test, it shows that op_Equality is overridden and distinguishes from reference equality (which neither VB or C# does, but someone might guess from "==")


[Fact]
public void NullEmptyStringEqualsOperator() => Assert.False((emptyString != null && nullString != null) && emptyString == nullString); //null == string.Empty in VB

[Fact]
public void NullEmptyStringNotEqualsOperator() => Assert.True(nullString != emptyString);
public void NullEmptyStringNotEqualsOperator() => Assert.True((emptyString == null && nullString != null) || (emptyString != null && nullString == null)); //null == string.Empty in VB

[Fact]
public void NullEmptyObjectEqualsOperator() => Assert.False(nullObject == emptyString);
Expand Down