Byref #566
Merged
Byref #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#567 has another case you might like to cover in this PR. |
GrahamTheCoder
commented
Mar 2, 2022
| } | ||
| return NeedsVariableForArgument(node, refKind); |
There was a problem hiding this comment.
#843 will probably need to be fixed within here - see other TODO: https://github.com/icsharpcode/CodeConverter/pull/566/files#r817528266
GrahamTheCoder
commented
Mar 2, 2022
| RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression) | ||
| { | ||
| var symbolInfo = GetSymbolInfoInDocument<ISymbol>(expression); | ||
| if (symbolInfo.IsKind(SymbolKind.Property)) return RefConversion.PreAndPostAssignment; |
There was a problem hiding this comment.
TODO: Should check for readonly property and return PreAssignment only
#843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
Fixes #310
Fixes #567