Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: HasAttribute/GetAttribute #1204

Closed
dgrunwald opened this issue Jul 14, 2018 · 1 comment
Closed

Performance: HasAttribute/GetAttribute #1204

dgrunwald opened this issue Jul 14, 2018 · 1 comment
Labels
Performance

Comments

@dgrunwald
Copy link
Member

Currently, every HasAttribute / GetAttribute call ends up decoding all attributes applied to the target entity. While custom attributes are relatively cheap (their argument values are only decoded at a later point); security declarations are expensive as they require full decoding of the permission blob.

But most of the known attributes cannot occur within security declarations, so a HasAttribute / GetAttribute check for them performs lots of redundant work.

This is especially relevant for AddDefinesForConditionalAttributes, which currently ends up calling GetAttributes() for the target of every call.
dgrunwald referenced this issue Nov 2, 2018
@siegfriedpammer
Fix #1287: Analysis 'applied to' of Attribute not working on special …
892a4da 
…attributes
siegfriedpammer added a commit that referenced this issue Jan 28, 2022
@siegfriedpammer
Optimize IsKnownType/IsKnownAttribute (see #1204 and #2594)
6533f75
siegfriedpammer added a commit that referenced this issue Feb 5, 2022
@siegfriedpammer
Optimize IsKnownType/IsKnownAttribute (see #1204 and #2594)
428c6bf
siegfriedpammer added a commit that referenced this issue Mar 7, 2022
@siegfriedpammer
Optimize IsKnownType/IsKnownAttribute (see #1204 and #2594)
02d143c
@dgrunwald dgrunwald mentioned this issue Jul 16, 2022
Open
7 tasks
@christophwille christophwille mentioned this issue Jul 16, 2022
Closed
siegfriedpammer added a commit that referenced this issue Jul 16, 2022
@siegfriedpammer
Work on #1204: Add optimized implementation of HasAttribute and GetAt…
02094e2 
…tribute to IEntity.
dgrunwald pushed a commit that referenced this issue Jul 16, 2022
@siegfriedpammer @dgrunwald
Work on #1204: Add optimized implementation of HasAttribute and GetAt…
834dd93 
…tribute to IEntity.
@dgrunwald dgrunwald mentioned this issue Aug 23, 2022
Merged
siegfriedpammer added a commit that referenced this issue Aug 24, 2022
@siegfriedpammer
Work on #1204: Add optimized implementation of HasAttribute and GetAt…
583f661 
…tribute to IEntity.
@siegfriedpammer
Copy link
Member

Fixed by #2765

hexafluoride pushed a commit to hexafluoride/ILSpy that referenced this issue Aug 31, 2022
@siegfriedpammer @hexafluoride
Work on icsharpcode#1204: Add optimized implementation of HasAttribut…
25804c4 
…e and GetAttribute to IEntity.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgrunwald @siegfriedpammer