-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag values to both "Characteristics" lists in Metadata Explorer #2138
Comments
Looks good to me. |
@siegfriedpammer Great. But, is there a preference between with
With |
The values look like flags anyway, so I think you can omit the 0x.
If I recall correctly, all values are hexadecimal with one single exception: the RID column. Your proposed change would also follow the current display of attributes/flags in tooltips. |
Done via #2145.
The "Value" column in the "DOS Header" tab / section is in decimal / integer format. Which is fine, at least for now. It would be nice to have both because I use some values to find something in the assembly, and I use other values to find the value itself. I'm not exactly sure what the real solution should be, especially because there are some "Meaning" entries that should be updated to include the value. And, I don't do this type of analysis frequently enough to make it a priority. If I ever have the time, I will open a separate issue for that. |
Fix #2138: Add flag values to both "Characteristics" lists in Metadata Explorer
Having the "Characteristics" lists in Metadata Explorer is great, but it would be even more helpful to see the individual values for each item in both lists. Doing so would make the relationship between the bitmasked value and the individual items that make up that value much clearer. I want to add the specific flag values to each of the individual options for both the "Characteristics" list (in "COFF Header") and the "DLL Characteristics" list (in "Optional Header"). The end-result being that we would see:
Or, it could be:
Or, it could be something else entirely.
Is there a preferred style? I'm using
<
and>
to keep them visually separate from the existing parenthetical values used at the end of the line in a few places:(Low)
,(High)
, and(SEH)
.I'm willing to make the change, but I first want to make sure that the format is acceptable.
Thanks, Solomon..
The text was updated successfully, but these errors were encountered: