Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag values to both "Characteristics" lists in Metadata Explorer #2138

Closed
srutzky opened this issue Sep 2, 2020 · 4 comments · Fixed by #2145
Closed

Add flag values to both "Characteristics" lists in Metadata Explorer #2138

srutzky opened this issue Sep 2, 2020 · 4 comments · Fixed by #2145
Labels
Enhancement Areas for improvement Help Wanted UI

Comments

@srutzky
Copy link
Contributor

srutzky commented Sep 2, 2020

Having the "Characteristics" lists in Metadata Explorer is great, but it would be even more helpful to see the individual values for each item in both lists. Doing so would make the relationship between the bitmasked value and the individual items that make up that value much clearer. I want to add the specific flag values to each of the individual options for both the "Characteristics" list (in "COFF Header") and the "DLL Characteristics" list (in "Optional Header"). The end-result being that we would see:

☑️  | <0x0002> File is executable
🟦  | <0x0004> Line numbers stripped from file
🟦  | <0x0008> Local symbols stripped from file
...
🟦  | <0x0080> Bytes of machine words are reversed (Low)

Or, it could be:

☑️  | <0002> File is executable
🟦  | <0004> Line numbers stripped from file
🟦  | <0008> Local symbols stripped from file
...
🟦  | <0080> Bytes of machine words are reversed (Low)

Or, it could be something else entirely.

Is there a preferred style? I'm using < and > to keep them visually separate from the existing parenthetical values used at the end of the line in a few places: (Low), (High), and (SEH).

I'm willing to make the change, but I first want to make sure that the format is acceptable.

Thanks, Solomon..

@siegfriedpammer
Copy link
Member

Looks good to me.

@srutzky
Copy link
Contributor Author

srutzky commented Sep 2, 2020

@siegfriedpammer Great. But, is there a preference between with 0x or without? As in:

<0x0080> vs <0080>

With 0x is clearer that the value is hex instead of decimal, but at least to me it doesn't look as nice as without. So far I am leaning towards without, but there are a few places in Metadata Explorer where I kinda wish it were a little clearer that the value is hex or decimal. Of course, after checking again, I don't see any place that has 0x, so probably best to leave that off for the sake of consistency.

@siegfriedpammer
Copy link
Member

Of course, after checking again, I don't see any place that has 0x, so probably best to leave that off for the sake of consistency.

The values look like flags anyway, so I think you can omit the 0x.

but there are a few places in Metadata Explorer where I kinda wish it were a little clearer that the value is hex or decimal.

If I recall correctly, all values are hexadecimal with one single exception: the RID column.

Your proposed change would also follow the current display of attributes/flags in tooltips.

image

@srutzky
Copy link
Contributor Author

srutzky commented Sep 4, 2020

The values look like flags anyway, so I think you can omit the 0x.

Done via #2145.

 

If I recall correctly, all values are hexadecimal with one single exception: the RID column.

The "Value" column in the "DOS Header" tab / section is in decimal / integer format. Which is fine, at least for now. It would be nice to have both because I use some values to find something in the assembly, and I use other values to find the value itself. I'm not exactly sure what the real solution should be, especially because there are some "Meaning" entries that should be updated to include the value. And, I don't do this type of analysis frequently enough to make it a priority. If I ever have the time, I will open a separate issue for that.

siegfriedpammer added a commit that referenced this issue Sep 4, 2020
Fix #2138: Add flag values to both "Characteristics" lists in Metadata Explorer
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Areas for improvement Help Wanted UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants