Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't open the .NET bundle file. #3197

Closed
wwh1004 opened this issue Apr 17, 2024 · 4 comments
Closed

Can't open the .NET bundle file. #3197

wwh1004 opened this issue Apr 17, 2024 · 4 comments
Labels
Bug

Comments

@wwh1004
Copy link
Contributor

wwh1004 commented Apr 17, 2024

Steps to reproduce

  1. Open a .NET bundle
  2. Fails

Error message shown

Details

LoadedAssembly.LoadAsync doesn't catch exceptions when thrown in "result = await loader.Load(fileName, stream, settings).ConfigureAwait(false);". If open an entry in bundled file, FileNotFoundException will be thrown and breaks logic of LoadAsync.

image
image
@wwh1004 wwh1004 added the Bug label Apr 17, 2024
@wwh1004
Copy link
Contributor Author

wwh1004 commented Apr 17, 2024

It seems that a logic to prioritize bundled entries should be added. If a file with the same name exists in the ILSpy directory, this file will be loaded first instead of loading the bundled entry.

@workgroupengineering
Copy link

The same issue exists for nuget packages

@workgroupengineering
Copy link

If i revert pr #3191 commit id 65e30c0 work

siegfriedpammer added a commit that referenced this issue Jun 2, 2024
@siegfriedpammer
Fix mysteriously deleted issue #3197: Skip file formats that currentl…
77b237d 
…y can only be loaded from a file when dealing with a file from a bundle or package.
@wwh1004
Copy link
Contributor Author

wwh1004 commented Jun 8, 2024

@siegfriedpammer My github account was suspended two weeks ago, and has been reinstated now.

@wwh1004 wwh1004 closed this as completed Jun 8, 2024
mattsh247 pushed a commit to mattsh247/ILSpy that referenced this issue Jul 30, 2024
@siegfriedpammer
Fix mysteriously deleted issue icsharpcode#3197: Skip file formats th…
d357c5f 
…at currently can only be loaded from a file when dealing with a file from a bundle or package.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@workgroupengineering @wwh1004