Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWE-252 The return value of function 'Reverse' is required to be utilized. #1305

Merged
merged 1 commit into from
Nov 3, 2018

Conversation

agametov
Copy link
Contributor

No description provided.

Fix reverse Assemblies.
@christophwille
Copy link
Member

After checking with @siegfriedpammer "Please don't force arbitrary code styles on our code base. The core team makes the rules, not some random tool."

@agametov
Copy link
Contributor Author

Example https://dotnetfiddle.net/CWipOa

@siegfriedpammer
Copy link
Member

siegfriedpammer commented Oct 24, 2018

Oh, sorry, my bad! That's what you get from reviewing pull requests on your phone while travelling. A better description of the problem in the pull request might have helped. I wonder why this was never noticed up to now...

It's not super critical, thanks for the fix though! Sorry, for dismissing this too early!

@agametov
Copy link
Contributor Author

No problem, @siegfriedpammer :-)
I thought this PR doesn`t need a detailed description because of one line.
Next time I will write a detailed description! :-)

@siegfriedpammer siegfriedpammer merged commit c9f40a0 into icsharpcode:master Nov 3, 2018
@siegfriedpammer
Copy link
Member

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants