Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several "Size" values in Optional Header #2134

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

srutzky
Copy link
Contributor

@srutzky srutzky commented Aug 31, 2020

Problem

All but the first of the UInt16 values were given a size of 4 when they really should be 2.

This is a minor issue as these values are for display only and do not affect the parsing of the metadata.

Solution

I simply changed the informational "Size" values on all but the first UInt16 item from 4 to 2 (8 items in total).

Take care,
Solomon...
https://SqlQuantumLeap.com/

P.S. I love this Metadata Explorer feature. Thank you very much for adding it 😺 .

P.P.S. I also checked the "DOS Header" and "COFF Header" values and all appear to be correct.

All of the UInt16 values were given a size of 4 when they really should be 2.
@siegfriedpammer siegfriedpammer merged commit 455ee92 into icsharpcode:master Aug 31, 2020
@siegfriedpammer
Copy link
Member

Thank you very much for spotting this!

@srutzky
Copy link
Contributor Author

srutzky commented Aug 31, 2020

@siegfriedpammer You are quite welcome. I have another one (related to this) coming in just a moment.

@srutzky srutzky deleted the patch-1 branch August 31, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants