Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url of SearchMsdn when do search with generic types and .ctor methods #2343

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

@siegfriedpammer
Copy link
Member

Maybe this will need adjustments for static constructors (.cctor) and operators (op_) as well?

@yyjdelete
Copy link
Contributor Author

yyjdelete commented Mar 19, 2021

operators already works
https://docs.microsoft.com/dotnet/api/system.decimal.op_explicit

.cctor should always be private and already be disabled by checks in bool IsEnabled(TextViewContext context).


But I'm not sure which is better for enum and delegate, add special logic for them to use DeclaringType instead, or simply disable it in IsEnabled, or just leave it as it is before.
There is only
https://docs.microsoft.com/en-us/dotnet/api/system.dayofweek
https://docs.microsoft.com/en-us/dotnet/api/system.action
but not
https://docs.microsoft.com/en-us/dotnet/api/system.dayofweek.sunday
https://docs.microsoft.com/en-us/dotnet/api/system.dayofweek.value__
https://docs.microsoft.com/en-us/dotnet/api/system.action.invoke

@siegfriedpammer
Copy link
Member

Enum values and delegate members should just return false for IsEnabled, I think.

@siegfriedpammer siegfriedpammer merged commit 24ddd7b into icsharpcode:master Mar 19, 2021
@siegfriedpammer
Copy link
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants