Add more theme colors #2952
Merged
Add more theme colors #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrzesniewski
force-pushed
the
themes-fixes
branch
from
8a7b3cc to
1106a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I missed a few items which themes should have customized in #2906:
Solution
Any comments on the approach taken, its consistency with surrounding code, etc.
The changes are pretty straightforward.
Which part of this PR is most in need of attention/improvement?
I also aligned the borders of highlighted brackets to whole pixels, as they were blurry otherwise.
Render examples: