Rework of reflection layer, "RoslynReflection" is now the central pla…

…ce lazily loading types and methods. This should fix #165. Had to add workarounds in 2 analyzers to avoid exceptions, their function currently depends on reflection usage.

RefactoringEssentials/CSharp/Diagnostics/Synced/Opportunities/ConvertClosureToMethodGroupAnalyzer.cs

@@ -51,6 +51,10 @@ static bool TryGetDiagnostic(SyntaxNodeAnalysisContext nodeContext, out Diagnost
             if (body == null)
                 return false;
 
+            // (Bad) workaround for usage of SignatureComparer in this analyzer, when Roslyn's Workspaces are not loaded
+            if (!RoslynReflection.SignatureComparer.IsAvailable())
+                return false;
+
             var invocation = AnalyzeBody(body);
             if (invocation == null)
                 return false;
@@ -106,8 +110,10 @@ static bool TryGetDiagnostic(SyntaxNodeAnalysisContext nodeContext, out Diagnost
                 {
                     if (otherMethod == method)
                         continue;
+#pragma warning disable RECS9000 // Using internal Roslyn features through reflection in wrong context.
                     if (SignatureComparer.HaveSameSignature(otherMethod.GetParameters(), invokeMethod.Parameters))
                         return false;
+#pragma warning restore RECS9000 // Using internal Roslyn features through reflection in wrong context.
                 }
             }
 

RefactoringEssentials/CSharp/Diagnostics/Synced/RedundanciesInCode/RedundantBaseQualifierAnalyzer.cs

@@ -47,15 +47,21 @@ static bool TryGetDiagnostic(SyntaxNodeAnalysisContext nodeContext, out Diagnost
             if (nodeContext.IsFromGeneratedCode())
                 return false;
 
+            // (Bad) workaround for usage of SpeculationAnalyzer in this analyzer, when Roslyn's Workspaces are not loaded
+            if (!RoslynReflection.SpeculationAnalyzer.IsAvailable())
+                return false;
+
             var node = nodeContext.Node as MemberAccessExpressionSyntax;
             if (node.Expression.IsKind(SyntaxKind.BaseExpression))
             {
                 var replacementNode = node.Name.WithLeadingTrivia(node.GetLeadingTrivia()).WithTrailingTrivia(node.GetTrailingTrivia());
+#pragma warning disable RECS9000 // Using internal Roslyn features through reflection in wrong context.
                 if (node.CanReplaceWithReducedName(replacementNode, nodeContext.SemanticModel, nodeContext.CancellationToken))
                 {
                     diagnostic = Diagnostic.Create(descriptor, node.Expression.GetLocation(), additionalLocations: new[] { node.OperatorToken.GetLocation() });
                     return true;
                 }
+#pragma warning restore RECS9000 // Using internal Roslyn features through reflection in wrong context.
             }
             return false;
         }

RefactoringEssentials/RefactoringEssentials.csproj

@@ -505,6 +505,7 @@
     <Compile Include="Util\GeneratedCodeRecognition.cs" />
     <Compile Include="Util\HelpLink.cs" />
     <Compile Include="Util\NRefactory6Host.cs" />
+    <Compile Include="Util\RoslynReflection.cs" />
     <Compile Include="Util\SyntaxExtensions.cs" />
     <Compile Include="Util\TypeExtensions.cs" />
     <Compile Include="Util\CSharpUtil.cs" />