Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate 0-value (missing) local size headers. #18

Merged
merged 1 commit into from
May 9, 2016

Conversation

hempels
Copy link
Contributor

@hempels hempels commented Oct 29, 2013

Some rogue zip creators fail to set a non-zero local header size in ExtraData causing SharpZLib to reject them, this patch allows the library to tolerate that particular oversight like most other libraries.

Some rogue zip creators fail to set a non-zero local header size in
Extra Data causing SharpZLib to reject them, this patch causes the
library to tolerate that particular oversight like most other libraries.
@superjulius
Copy link

Any plan or idea if this change will be merged. I am facing the same problem with some users and I would prefer to use a new release instead of recompiling the lib.

@McNeight McNeight self-assigned this Apr 14, 2016
@McNeight McNeight added the bug label Apr 14, 2016
@McNeight McNeight mentioned this pull request Apr 14, 2016
@McNeight McNeight added the zip Related to ZIP file format label Apr 15, 2016
@McNeight McNeight merged commit b7ebd22 into icsharpcode:master May 9, 2016
@McNeight McNeight modified the milestone: 1.0 May 17, 2016
McNeight added a commit that referenced this pull request Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug zip Related to ZIP file format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants