Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensor-capture-disk-config.py not detecting disks correctly #239

Closed
mmguero opened this issue Aug 16, 2023 · 0 comments
Closed

sensor-capture-disk-config.py not detecting disks correctly #239

mmguero opened this issue Aug 16, 2023 · 0 comments
Assignees
@mmguero
Labels
bug Something isn't working regression It worked at one point... sensor For issues dealing with the Hedgehog OS capture sensor
Milestone
v23.08.1

Comments

@mmguero
Copy link
Collaborator

mmguero commented Aug 16, 2023

Used by Hedgehog, sensor-capture-disk-config.py is not detecting disks correctly, which causes the disks not to be formatted. This is a regression due to the refactoring I did a release or so ago. Need to replace the use of run_process with run_subprocess in that file.
@mmguero mmguero added bug Something isn't working regression It worked at one point... sensor For issues dealing with the Hedgehog OS capture sensor labels Aug 16, 2023
@mmguero mmguero added this to the v23.08.1 milestone Aug 16, 2023
@mmguero mmguero self-assigned this Aug 16, 2023
@mmguero mmguero added this to Malcolm Aug 16, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 16, 2023
@mmguero
fix idaholab/idaholab#239, sensor-capture-disk-config.py not detectin…
2ce0a70 
…g disks correctly
@mmguero mmguero moved this to Done in Malcolm Aug 16, 2023
@mmguero mmguero closed this as completed Aug 16, 2023
This was referenced Aug 16, 2023
Closed
Merged
Merged
@mmguero mmguero moved this from Done to Released in Malcolm Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
bug Something isn't working regression It worked at one point... sensor For issues dealing with the Hedgehog OS capture sensor
Projects
Malcolm
Status: Released
Milestone
v23.08.1
Development

No branches or pull requests
1 participant
@mmguero