Implement AsyncTask for heavy computation to unblock UI thread #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
👍 |
grunch
reviewed
Oct 2, 2016
| if(CURRENT_TASK == null || CURRENT_TASK.getStatus() == AsyncTask.Status.FINISHED ) { | ||
| if(camera != null) { | ||
| // AsyncTask expects one parameter, so I wrap data and camera in a class | ||
| ProcessFrameData frameDataHeloer = new ProcessFrameData(data, camera); |
There was a problem hiding this comment.
@AlexSchwabauer Maybe you want to change "frameDataHeloer" for "frameDataHelper" :)
|
@andreaskeller Barcode scanning on android is added to react-native-camera now. It's worth joining hands with react-native-camera or adding in ios support here and claim barcode scanning only module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the bottleneck of this module is the barcode detection logic which is done on each frame.
Unfortunately, this computation is quite expensive and blocks the UI and leads to bad performance.
This pull request wraps the logic of BarcodeScannerView.onPreviewFrame in an AsyncTask to free the UI thread.