Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore Examples/BarcodeScanner/android/app/build #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bestander
Copy link

Current npm package is 12MB because it includes build folder.
This PR makes deep build folders to be excluded

Current npm package is 12MB because it includes build folder.
This PR makes deep build folders to be excluded
@bestander
Copy link
Author

@ideacreation, I would really appreciate if you could release a new patch for your package, this works really great for us but because the package is large we are blocked from proceeding.

@bestander
Copy link
Author

cc @andreaskeller

@chirag04
Copy link
Contributor

chirag04 commented Dec 9, 2016

@bestander is fb using this package?

@bestander
Copy link
Author

@chirag04, one of the internal apps is going to.

@chirag04
Copy link
Contributor

chirag04 commented Dec 9, 2016

nice. btw, react-native-camera now supports both ios and android barcode scanning. wondering y not use react-native-camera.

(no offence to the creators of this package. this package is awesome and i'm using it)

@bestander
Copy link
Author

Ping, any chance anyone sees this?

@chirag04
Copy link
Contributor

i guess not. readme is updated to say react-native-barcodescanner - not maintained anymore - use react-native-camera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants