Extend elasticsearch_index resource capabilities + fix issue #38

[Amos-85]

This PR solve issue #38 and extend capabilities of elasticsearch_index

The problem of var.indices as map(any) lead terraform raising an exception when defining nested maps in mappings attribute or any other string JSON that converted by jsonencode function from map(any) to string.

Terraform issue mentioned here about nested maps within map(any) variable .

Terraform Error:

• cannot find a common base type for all elements

Expected behavior:

• Defining nested maps inside JSON string attribute of terraform resource elasticsearch_index schema

Required Configuration E.g:

indices = {
    example-index-1 = {
      number_of_shards   = 2
      number_of_replicas = 1
    }
    example-index-2 = {
      number_of_shards   = 2
      number_of_replicas = 1
      mappings           =<<-EOF
      {
        "properties": {
          "id": {
            "type": "text"
          },
          "name": {
            "type": "text"
          },
          "containerType": {
            "type": "text"
          },
          "containerIds": {
            "type": "text"
          },
          "synonyms": {
            "type": "text"
          },
          "parentEvents": {
            "type": "text"
          },
          "valueType": {
            "type": "text"
          }
        }
      }
    EOF
    }
  }

Suggested Solution:

• Using terraform intended heredoc by changing var.indices to defined map object and use string variable in all JSON objects.

[steveteuber]

Hi @Amos-85, thanks for your pull request.

That's really cool, i like it! But it's a breaking change.
This change will replace all indices in already existing clusters.

I think we should merge it when we switch to the new Terraform provider for OpenSearch.

[amontalban]

Hi @Amos-85, thanks for your pull request.

That's really cool, i like it! But it's a breaking change. This change will replace all indices in already existing clusters.

I think we should merge it when we switch to the new Terraform provider for OpenSearch.

@steveteuber do you have a timeline for the OpenSearch provider migration? I have some needs that unfortunately this module doesn't offer and would like to help with the migration but not sure if it is an undergoing effort or it hasn't started yet.

Thanks!

[steveteuber]

Hi @amontalban, I will start the migration next week.

[github-actions]

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀