chore: adds condition to compare principal id

idealo · Jan 8, 2025 · 4eb4cc7 · 4eb4cc7
1 parent b9736bf
commit 4eb4cc7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/internal/provider/resource_aws_account.go b/internal/provider/resource_aws_account.go
@@ -452,8 +452,9 @@ func updateAccountAssignment(ctx context.Context, d *schema.ResourceData, ssoadm
 	sso := d.Get("sso").([]interface{})[0].(map[string]interface{})
 	instanceArn := sso["instance_arn"].(string)
 	oldPrincipalId := oldSSOMap["principal_id"].(string)
+	newPrincipalId := newSSOMap["principal_id"].(string)
 
-	if oldEmail != newEmail && oldPrincipalId != "" && instanceArn != "" {
+	if oldEmail != newEmail && oldPrincipalId != newPrincipalId && oldPrincipalId != "" && instanceArn != "" {
 
 		_, err := ssoadmincon.DeleteAccountAssignment(ctx, &ssoadmin.DeleteAccountAssignmentInput{
 			InstanceArn:   &instanceArn,