Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to fire an individual scene #138

Closed
wants to merge 1 commit into from

Conversation

jordansnyder
Copy link

Adds functionality to support firing a scene with OSC message "/live/song/fire/scene {sceneIndex}"

@ziginfo
Copy link

ziginfo commented Aug 30, 2024

great Job !!
Many Thanks for that !!
cheers and friendly greetings ! :)

@esaruoho
Copy link
Contributor

@ideoforms is this worth merging in? :)

@ideoforms
Copy link
Owner

Thanks for the PR @jordansnyder !
I've not yet merged this as I want to put a bit of time into considering whether scenes need their own separate namespace, so don't want to add this endpoint only to remove it later.

I'm glad to say that I am about to have much more time to devote to AbletonOSC, so this and other issues will be tackled in the near future.

@jordansnyder
Copy link
Author

Hey no sweat, and that makes perfect sense! To be fair, I saw that someone else had done this exact same addition in another fork, but they just didn't create a PR and I felt it was worthwhile. But it totally makes sense to consider the namespace/organization, I wasn't completely sold on this structure. Thanks for supporting this project, it's been super helpful!

@esaruoho
Copy link
Contributor

esaruoho commented Sep 29, 2024

would /live/scene/fire make sense?

wdyt, @ideoforms ?

@ziginfo
Copy link

ziginfo commented Sep 30, 2024

/live/scene/fire ... would be great ! but any other "convention" could do also...
I use the fire-scene-add-on of "jordansnyder" since he published this on his Github and cannot imagine to go back to the "without" this option
so.... integrate this Pull-Request into Daniel's source-code would really be a GREAT add-on !
hopefully soon ??
cheers and friendly greetings

@Coupe70
Copy link

Coupe70 commented Oct 27, 2024

would /live/scene/fire make sense?

I think this would be right as it's similarly to
/live/clip/fire
Hoping for this for a long time.

@esaruoho
Copy link
Contributor

esaruoho commented Nov 9, 2024

@jordansnyder do you think you could modify this to be /live/scene/fire maybe?
and then we could see if @ideoforms will merge this in

@jordansnyder
Copy link
Author

@jordansnyder do you think you could modify this to be /live/scene/fire maybe? and then we could see if @ideoforms will merge this in

Hey yeah I can definitely do that, great suggestion! Sorry, been away for a while.

@Coupe70
Copy link

Coupe70 commented Jan 26, 2025

@ideoforms
Any chance to get this implemented in the near future?
It's my #1 feature wish to complete a clip launcher and it has been done, but is pending for quite some time now...

@ideoforms
Copy link
Owner

You got it @Coupe70, this has been on my mind too so I'll see about getting this tidied and merged in the next couple of days. 🏃🏻

@ideoforms
Copy link
Owner

I'm happy to say I've now added the long-overdue ability to fire a scene from the AbletonOSC API!

There is a new SceneHandler class, and the method to call is /live/scene/fire [scene_index].
I will later add methods to get/set other Scene properties (name, color, etc), but I know this is the major one.

Please let me know how you all get on.

@jordansnyder I'm afraid I will close this PR, as the new code is in a different class altogether, but I appreciate the contribution nonetheless.

@ideoforms ideoforms closed this Jan 28, 2025
@ziginfo
Copy link

ziginfo commented Jan 28, 2025

Great news and thanks a lot for this...
cheers and friendly greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants