-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ability to fire an individual scene #138
Conversation
great Job !! |
@ideoforms is this worth merging in? :) |
Thanks for the PR @jordansnyder ! I'm glad to say that I am about to have much more time to devote to AbletonOSC, so this and other issues will be tackled in the near future. |
Hey no sweat, and that makes perfect sense! To be fair, I saw that someone else had done this exact same addition in another fork, but they just didn't create a PR and I felt it was worthwhile. But it totally makes sense to consider the namespace/organization, I wasn't completely sold on this structure. Thanks for supporting this project, it's been super helpful! |
would wdyt, @ideoforms ? |
/live/scene/fire ... would be great ! but any other "convention" could do also... |
I think this would be right as it's similarly to |
@jordansnyder do you think you could modify this to be |
Hey yeah I can definitely do that, great suggestion! Sorry, been away for a while. |
@ideoforms |
You got it @Coupe70, this has been on my mind too so I'll see about getting this tidied and merged in the next couple of days. 🏃🏻 |
I'm happy to say I've now added the long-overdue ability to fire a scene from the AbletonOSC API! There is a new SceneHandler class, and the method to call is Please let me know how you all get on. @jordansnyder I'm afraid I will close this PR, as the new code is in a different class altogether, but I appreciate the contribution nonetheless. |
Great news and thanks a lot for this... |
Adds functionality to support firing a scene with OSC message "/live/song/fire/scene {sceneIndex}"