Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: client_secret_basic client authentication method requires a client_secret #2

Closed
robbertkl opened this issue Dec 4, 2019 · 3 comments
Closed

TypeError: client_secret_basic client authentication method requires a client_secret #2

robbertkl opened this issue Dec 4, 2019 · 3 comments

Comments

@robbertkl
Copy link
Contributor

After applying simplyGits/MagisterJS#150 and #1, I'm still getting this error from within getTokenSet():

TypeError: client_secret_basic client authentication method requires a client_secret

Please note I'm not getting this error when using the latest magister.js release (2.0.0-alpha.12, which does not yet use magister-openid) with a manually applied change to the new challenge URLs.
@idiidk idiidk closed this as completed in 3d1e20f Dec 5, 2019
@idiidk
Copy link
Owner

idiidk commented Dec 5, 2019

Pretty strange that this broke. Just added token_endpoint_auth_method: "none" to the client initialization which fixes it. Don't know why it worked in the first place tho. Sometimes code is just weird I guess :D

Thanks for the pull request btw!

@robbertkl
Copy link
Contributor Author

Awesome, thanks for the fix. Will there be a new version release?

@idiidk
Copy link
Owner

idiidk commented Dec 5, 2019

Pushed 0.1.5 to npm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robbertkl @idiidk