Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems a couple of days ago the challenge URLs were changed. This PR addresses this (they simply got renamed from
/challenge
to/challenges
.It works for me when using the latest release (2.0.0-alpha.12) of magister.js and then manually changing
challenge
tochallenges
. I wanted to submit a PR there with the rename, but noticed that since the last release, the authentication was moved to (replaced by) this library, so now I created my PR here.When trying to get everything working with magister.js master branch and this library I ran into some issues:
TypeError: client_secret_basic client authentication method requires a client_secret
ingetTokenSet()
I haven't been able yet to solve this last error, but at least this PR gets it a few steps further down the authentication flow. I'll put the error in a separate issue. Please note I did not have this error when changing the challenge URL manually in an older version of magister.js.