Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass eventTarget to onClickOutside #72

Merged
merged 1 commit into from
Oct 13, 2021
Merged

feat: pass eventTarget to onClickOutside #72

merged 1 commit into from
Oct 13, 2021

Conversation

idoros
Copy link
Owner

@idoros idoros commented Oct 13, 2021 •
edited
Loading

This PR passes the event.target that triggers an onClickOutside to the handlers.

This is useful when the outside layer wants to prevent certain "outside" elements from closing the layer (e.g. when the anchor element outside should not close the layer).

@idoros idoros added the feature New feature or request label Oct 13, 2021
@idoros idoros changed the title feat: pass eventTarget to clickOutside feat: pass eventTarget to onClickOutside Oct 13, 2021
@idoros idoros merged commit b195a58 into master Oct 13, 2021
@idoros idoros deleted the ido/click-outside-target branch October 13, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@idoros