Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIDs that are not yet downloaded should not count as available for sharing #12

Closed
celinenilla opened this issue Feb 10, 2022 · 1 comment · Fixed by #43
Closed

VIDs that are not yet downloaded should not count as available for sharing #12

celinenilla opened this issue Feb 10, 2022 · 1 comment · Fixed by #43
Assignees
@pmigueld
Labels
enhancement New feature or request
Milestone
0.2.1

Comments

@celinenilla
Copy link
Collaborator

celinenilla commented Feb 10, 2022 •
edited
Loading

Current behaviour:
When download takes long enough or there is an issue so that user goes to sharing screen before VC is downloaded, the VC under download will still be displayed as selectable. This also means that if there are no fully downloaded VC it is still possible to initiate sharing.

Expected behaviour:
Not fully downloaded VC should count as non existent VC when it comes to sharing

Image from iOS (1)
@kneckinator kneckinator added the enhancement New feature or request label Feb 10, 2022
@kneckinator kneckinator transferred this issue from another repository Feb 15, 2022
@kneckinator kneckinator added this to the 0.2.1 milestone Feb 15, 2022
@danicaerediano danicaerediano self-assigned this Feb 16, 2022
@pmigueld pmigueld assigned pmigueld and unassigned danicaerediano Feb 16, 2022
@pmigueld pmigueld mentioned this issue Feb 17, 2022
Merged
@pmigueld pmigueld linked a pull request Feb 17, 2022 that will close this issue
Filter shareable VIDs #43
Merged
@pmigueld pmigueld removed their assignment Feb 17, 2022
@kneckinator kneckinator reopened this Feb 22, 2022
@pmigueld pmigueld self-assigned this Feb 28, 2022
@celinenilla
Copy link
Collaborator Author

celinenilla commented Mar 21, 2022 •
edited
Loading

Verified on 0.2.1 RC3. Working as expected.

pmigueld pushed a commit that referenced this issue Jan 26, 2024
@ravikp
Merge pull request #12 from ravikp/increase-max-size-of-async-storage
3f79c4f 
fix(mosip#616): Increase async storage limit to 30mb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmigueld pmigueld

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.1
Development

Successfully merging a pull request may close this issue.

Filter shareable VIDs idpass/inji
4 participants
@pmigueld @kneckinator @celinenilla @danicaerediano