-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser refactor #3450
base: main
Are you sure you want to change the base?
Parser refactor #3450
Conversation
Alrighty I guess I'm cleaning up those ideMode tests too because currently they're a nightmare to deal with. |
It turns out there was a very easy change (involving typecase) that adds a lot of information to semantic decorations, so the tests have been adapted. |
567a84f
to
2171166
Compare
badd3fb
to
195c6b6
Compare
I've just been reading some of this PR to see if I can make any constructive comments. Would it be feasible to pull the WithFC changes into a different PR to the extent they don't involve new code? That seems to make up a substantial chunk of the code in this PR st first blush. |
What changes in particular are you thinking of? It feels like it would be easiest to split off the changes of the test suite with the changes to the surface syntax tree. |
At a glance it looked like the total number of changed lines could be reduced a fair bit by moving the (mostly trivial) |
Alright. I'll see what I can do |
On hold until #3460 |
* Attempt to remove stateful semantic decoration * Remove redundant semantic coloring functions
7ce5749
to
e8f8aa5
Compare
Rebased and ready to review again |
Description
Apologies, this PR blew up. Those changes aim to simplify some aspects of the parser, by moving some of its logic into the desugarer. It contains:
fcBounds
to keep track of locations, rather than thread the locations manuallyIf I had more time I would have written a shorter PR.
Merry Christmas