chore(deps): remove pydyf pin, update weasyprint req #8580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should come back when we use xml2rfc for PDF generation
kesara
approved these changes
Feb 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8580 +/- ##
==========================================
- Coverage 88.88% 88.79% -0.09%
==========================================
Files 312 314 +2
Lines 40891 41213 +322
==========================================
+ Hits 36345 36596 +251
- Misses 4546 4617 +71 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the
[pdf]extra from thexml2rfcrequirement. That is ok for now because we don't usexml2rfcto generate PDFs. When we do that, we should bring the extra back.(If we want to keep that, we could just wait until ietf-tools/xml2rfc#1215 merges, but I think it's better not to tightly couple the releases.)