fix: more submission date feedback; refactor xml2rfc log capture #8621
+232
−103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal: log helpful feedback on more (hopefully now all!) paths where a
<date>
fails parsing or interpretation.Throws in some refactoring to centralize capture of the xml2rfc log output. This is done with the
capture_xml2rfc_output
context manager. A known side effect of the refactoring in 3529f14 is thatxml2rfc.log.write_out
andxml2rfc.log.write_err
will be restored to their original streams after each call torender_missing_formats()
instead of being left pointing at otherwise abandonedStringIO
instances. I think that's a win, but wanted to call it out as a possibly non-obvious change.