Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more submission date feedback; refactor xml2rfc log capture #8621

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jennifer-richards
Copy link
Member

Main goal: log helpful feedback on more (hopefully now all!) paths where a <date> fails parsing or interpretation.

Throws in some refactoring to centralize capture of the xml2rfc log output. This is done with the capture_xml2rfc_output context manager. A known side effect of the refactoring in 3529f14 is that xml2rfc.log.write_out and xml2rfc.log.write_err will be restored to their original streams after each call to render_missing_formats() instead of being left pointing at otherwise abandoned StringIO instances. I think that's a win, but wanted to call it out as a possibly non-obvious change.

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (70bf2ae) to head (e61d78a).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
ietf/submit/utils.py 78.94% 8 Missing ⚠️
ietf/utils/xmldraft.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8621      +/-   ##
==========================================
- Coverage   88.88%   88.80%   -0.08%     
==========================================
  Files         312      314       +2     
  Lines       40891    41221     +330     
==========================================
+ Hits        36345    36606     +261     
- Misses       4546     4615      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kesara kesara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants