chore: configure gunicorn secure_scheme_headers #8630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can tell it'll be ok to make the change to the django config, but I don't think we should do that right before a meeting just in case. I'm going to close this and create distinct PRs instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of training Django to look at the request headers, this configures gunicorn only to respect
X-Forwarded-Proto. It setswsgi.url_scheme, which is used by Django'srequest.is_secure()to decide whether a forwarded request is actually secure.Draft while I look back to make sure there wasn't some other corner where we needed the
SECURE_PROXY_SSL_HEADERsetting.