-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update subseries presentation #1102
Conversation
This fix's HTML output matches the current HTML output. However, the text output has line breaks in the URLs, whereas the current layout for text output starts the URL on a new line to prevent some of these breaks. |
(off-topic comment: This appears to be one more case where <nobr functionality would help, this time in the bowels of xml2rfc.) |
728f880
to
73c7b80
Compare
@ajeanmahoney, I've made appropriate changes. Can you recheck the example outputs? Thanks. |
7549f1d
to
8fe62fb
Compare
I've approved, but wait for @ajeanmahoney review as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text output is missing a period between the URL and the "At the time of writing" sentence (the period is there in the HTML and PDF outputs).
The extrapolated URL (when the target is not given) for a STD, BCP, or FYI should be of the form <https://www.rfc-editor.org/info/...>
. Currently it shows, for example, <https://www.rfc-editor.org/std/std1>
For the non-subseries referencegroup output, I'd like to see one that contains multiple references, both with and without a target, thanks!
8fe62fb
to
8685b57
Compare
When referencegroup target is missing, insert the target for BCP, STD and FYI.
8685b57
to
43a33a8
Compare
I've fixed this.
I've fixed this too.
See updated files:
|
Can you do an example that has a referencegroup mixed from references to different subseries? |
@cabo, RPC confirmed that RFCs are not shared between different subseries. |
I'm fine with this behavior (first reference determines processing) -- I just wanted to make sure that we have considered this (non-)use case. |
@ajeanmahoney Any issues with the output changes in #1102 (comment)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the test outputs, and it looks good.
Fixes #1100
With 205c09c,
xml2rfc
tries to add the correct target for subseries whenreferencegroup
'starget
attribute is missing.Updated examples: