Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rotation #326

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Document rotation #326

merged 2 commits into from
Jul 22, 2019

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Jul 12, 2019

No description provided.

@retokromer
Copy link
Contributor

retokromer commented Jul 13, 2019

I suggest to add here specular images as well (vertical and/or horizontal flipping), because it’s of the same family.

Context: One film reel can be digitised emulsion to sensor or base to sensor, from platter A to platter B or from platter B to platter A, and there are four combinations for the rotation of the platters. In case of highly damaged films, it’s actually the film itself who decides which configuration is chosen, not the operating person (no joke!). It’s useful when the raw scan can be played correctly without having to modify the player’s parameters.

@robUx4 robUx4 added clarifications spec_main Main Matroska spec document target labels Jul 13, 2019
@dericed dericed mentioned this pull request Jul 13, 2019
@dericed
Copy link
Contributor Author

dericed commented Jul 13, 2019

@retokromer I added a new issue for your idea rather than extend the scope of the pr, see #327

@retokromer
Copy link
Contributor

@dericed That’s fine with me. Thank you!

Copy link
Contributor

@robUx4 robUx4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me but adding ProjectionPoseYaw we should probably mention a rotation on what axis or in more simple terms what kind of rotation this is.

@dericed
Copy link
Contributor Author

dericed commented Jul 22, 2019

I'm going to merge as IMHO this pr address #269. @retokromer if you want please move your comment in #326 (comment) to a new issue, I'll consider it out of scope with this pr.

@dericed dericed merged commit f480ed4 into master Jul 22, 2019
@dericed dericed deleted the document-rotation branch July 22, 2019 16:19
@retokromer retokromer mentioned this pull request Jul 22, 2019
@retokromer
Copy link
Contributor

@dericed Done in #330.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarifications spec_main Main Matroska spec document target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants