Don't redefine and misuse ETHASH_MIX_BYTES #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ProgPoW source tree changed the value of
ETHASH_MIX_BYTES
from 128 to 256 and made use of it for ProgPoW specifics while at the same time assuming that Ethash DAG is computed ignoring this macro and using the old value of 128. That was weird. This PR tries to fix that and it also paves the way for experiments with adjusting the value ofPROGPOW_DAG_LOADS
.I tested that this compiles (both CUDA and OpenCL) and reports the same speeds as before. I didn't test that it actually computes the same hash values as before - is there a debugging mode included to test that?