Resolve incompatibility with Rails 7.1. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solargraph-rails causes an error when a project users Rails 7.1. This is caused by the lack of "present?" method in schema.rb. Details: - ActiveSupport does not guarantee providing "present?" method when a user requires 'active_support/core_ext/string/inflections'. - I replace "ns.namespace.present?" with "ns.namespace && !ns.namespace.empty?". - I also add "require 'activesupport' to "solargraph-rails.rb" because a user always need to add "require 'activesupport'" even if he/she uses partial functions provided by ActiveSupport according to the following article. https://guides.rubyonrails.org/active_support_core_extensions.html
|
This will resolve #60 |
|
@iftheshoefritz is it possible to make a release with this PR? |
|
@iftheshoefritz ping! Could we please get a new release? |
|
This is just for your information. |
|
@iftheshoefritz Can you release a new version? |
|
@iftheshoefritz ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solargraph-rails causes an error when a project users Rails 7.1. This is caused by the lack of "present?" method in schema.rb.
Details:
ns.namespace.present?withns.namespace && !ns.namespace.empty?.require 'activesupport'to "solargraph-rails.rb" because a user should addrequire 'activesupport'even if he/she uses partial functions provided by ActiveSupport according to the following article.https://guides.rubyonrails.org/active_support_core_extensions.html