fix: Create Fundraiser Redirection #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit d9aa366): https://ignite-new--pr150-jose-fix-create-fund-u3gvpig3.web.app (expires Sat, 18 Jun 2022 02:40:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
JoseRFelix
requested review from
marinhoarthur,
Matthews3301,
darika-dev and
fadeev
Base automatically changed from
jose/fix/validator-list
to
jose/feat/toggle-between-chains-requests
June 14, 2022 00:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #146
Considerations
This PR does not aim to completely overhaul the experience of the form by removing the redirection, but rather fix the current forceful sign in redirection. Along these lines, we should start brainstorming on what the form will look like when the user's wallet is not connected.
Future Improvements
The current
create fundraiser formresembles a monolith. We should refactor it by creating smaller components to favor composition and logic clarity.