Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix integration tests and lint workflows #3700

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

jeronimoalbi
Copy link
Member

These changes fix some issues that are causing that some PR test workflows are failing

@jeronimoalbi jeronimoalbi self-assigned this Oct 17, 2023
@jeronimoalbi
Copy link
Member Author

These changes are part of #3696 but I'm making a separate PR in case we need the fixes before.

@jeronimoalbi jeronimoalbi added the skip-changelog Don't check changelog for new entries label Oct 17, 2023
@jeronimoalbi
Copy link
Member Author

Go 1.21 introduced toolchain support. This new feature requires that GOSUMDB is enabled to be able to download higher Go toolchain versions but we disable it because sumdb times out, the reason is that the CLI repository size is too big; So, toolchain must also be disabled while GOSUMDB is off.

A part from that, to be able to update golangci-lint we have to make sure a recent Go version is being used by the CI workflows because newer toolchain versions won't be automatically downloaded.

@jeronimoalbi jeronimoalbi marked this pull request as ready for review October 17, 2023 13:22
- uses: actions/setup-go@v4
if: env.GIT_DIFF
with:
go-version: '1.21'
go-version: 'stable'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pantani Pantani merged commit 290fc63 into main Oct 18, 2023
28 of 29 checks passed
@Pantani Pantani deleted the ci/fix-lint-workflow branch October 18, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants