Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct ignite app gRPC server stop issue #3831

Merged
merged 4 commits into from
Dec 11, 2023
Merged

fix: correct ignite app gRPC server stop issue #3831

merged 4 commits into from
Dec 11, 2023

Conversation

jeronimoalbi
Copy link
Member

Closes #3749

@jeronimoalbi jeronimoalbi added type:bug Something isn't working component:extensions Related to Ignite Extensions. labels Dec 8, 2023
@jeronimoalbi jeronimoalbi self-assigned this Dec 8, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. labels Dec 8, 2023
@jeronimoalbi jeronimoalbi marked this pull request as ready for review December 8, 2023 12:06
Pantani
Pantani previously approved these changes Dec 8, 2023
View reviewed changes
julienrbrt
julienrbrt approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeronimoalbi jeronimoalbi merged commit 94116d8 into main Dec 11, 2023
43 checks passed
@jeronimoalbi jeronimoalbi deleted the fix/grpc-server-stop-race branch December 11, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@Ehsan-saradar Ehsan-saradar Ehsan-saradar approved these changes

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:extensions Related to Ignite Extensions. type:bug Something isn't working type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: plugin protocol data race
4 participants
@jeronimoalbi @Pantani @Ehsan-saradar @julienrbrt